Update readme and dependencies #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ignatk
reviewed
Jul 11, 2022
README.md
Outdated
| ``` | ||
| go get github.com/cloudflare/gokey/cmd/gokey | ||
| go install github.com/cloudflare/gokey/cmd/gokey |
There was a problem hiding this comment.
should this be go install github.com/cloudflare/gokey/cmd/gokey@latest?
$ go install github.com/cloudflare/gokey/cmd/gokey
go: 'go install' requires a version when current directory is not in a module
Try 'go install github.com/cloudflare/gokey/cmd/gokey@latest' to install the latest version
There was a problem hiding this comment.
Whoops! Yes it should be either @latest or @master since there hasn’t been a release in a while.
There was a problem hiding this comment.
can we actually do @latest please? (in case we would migrate from master to main) and can you squash the commit with the "update the readme" one?
There was a problem hiding this comment.
Ok done! Just make sure to do a release once this is in.
|
Great work on this one! Once this is merged, it also has to be released as a minor update. |
|
Thank you for the contribution |
This was referenced Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this tool on HN and figured I'd give it some love.
Closes #38
Closes #45