Update README.md #51
Closed
Update README.md #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignatk
reviewed
Jul 21, 2022
| @@ -71,7 +71,7 @@ The `gokey` binary should appear in your `$GOPATH/bin` directory. (Default | |||
| **gokey** can generate passwords and cryptographic private keys (ECC and RSA | |||
| keys are currently supported). However, without any additional options | |||
| specified it uses your master password as a single source of entropy for | |||
| generated data. For passwords it is acceptable most of the time, but keys | |||
| generated data. For passwords, it is acceptable most of the time, but keys | |||
There was a problem hiding this comment.
this sounds a bit weird in my head
| @@ -8,7 +8,7 @@ | |||
| **gokey** is a password manager, which does not require a password vault. | |||
| Instead of storing your passwords in a vault it derives your password on the | |||
| fly from your master password and supplied _realm_ string (for example, | |||
| resource URL). This way you do not have to manage, backup or sync your password | |||
| resource URL). This way you do not have to manage, backup, or sync your password | |||
There was a problem hiding this comment.
we already have or as a separator here - is this an Oxford comma?
| @@ -80,7 +80,7 @@ password as a source of entropy. | |||
|
|
|||
| #### Simple mode (without a seed file) | |||
|
|
|||
| In simple mode passwords are derived directly from your master password and the | |||
| In simple mode, passwords are derived directly from your master password and the | |||
|
Closing as no response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This README is already well written but I have some suggestions about grammar.