Add optional -usr command line parameter.
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2017 12:03
Useful in cases where you have multiple accounts for the same service but you don't want to use the same password for each. This does not break compatibility with older versions of gokey, since when `-usr` is not specified passwords are generated as before.
|
I'm not entirely sure about it. While the case is definitely useful, this opens a path to a bunch of similar cases: what if we want to differentiate on OS groups as well, or service path, or hostname or whatever etc... The bottomline is that tool has to be as generic as possible. That's why we just provide realm, but it is up to the caller to identify the "composition" of the realm. |
|
You're right. I'm going to close this pull request then. (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful in cases where you have multiple accounts for the same service but you don't want to use the same password for each. This does not break compatibility with older versions of gokey, since when
-usris not specified passwords are generated as before.