upgrade lz4 to r131 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. This fixes the segfault crashes on modern Linux releases like Alpine 3.4 and Ubuntu 15.10 |
flapjack103
referenced
this pull request
in DataDog/golz4
Nov 13, 2019
[lz4] try readfull when reading header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of bugs including a segfault crasher on GCC > 5.x (maybe > 4.9?) related to codegen on undefined behavior in
LZ4_copy8/LZ4_copy4which have since had their clever bits replaced by calls to memcpy. The HC tests, which were failing, also now pass.changelogs: https://github.com/Cyan4973/lz4/releases
The only oddity is that the test corpus doesn't compress as well and that test had to be updated.