This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Avoid breaking changes - The original path has higher priority #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
changed the title
SukkaW
commented
Jun 6, 2020
| '%not-really-percent-encoded.123HASHBROWN.html': 'browser percent encoded', | ||
| '%2F.123HASHBROWN.html': 'user percent encoded', | ||
| '你好.123HASHBROWN.html': 'I shouldnt be served', | ||
| '%E4%BD%A0%E5%A5%BD.123HASHBROWN.html': 'Im important', |
There was a problem hiding this comment.
%E4%BD%A0%E5%A5%BD is URL encoded 你好.
After this PR, only %E4%BD%A0%E5%A5%BD.html will be served even when /你好.html is requested.
SukkaW
commented
Jun 6, 2020
Comment on lines
+91
to
+113
| test('getAssetFromKV supports browser percent encoded URLs', async t => { | ||
| mockGlobal() | ||
| const event = getEvent(new Request('https://example.com/%not-really-percent-encoded.html')) | ||
| const res = await getAssetFromKV(event) | ||
|
|
||
| if (res) { | ||
| t.is(await res.text(), 'browser percent encoded') | ||
| } else { | ||
| t.fail('Response was undefined') | ||
| } | ||
| }) | ||
|
|
||
| test('getAssetFromKV supports user percent encoded URLs', async t => { | ||
| mockGlobal() | ||
| const event = getEvent(new Request('https://blah.com/%2F.html')) | ||
| const res = await getAssetFromKV(event) | ||
|
|
||
| if (res) { | ||
| t.is(await res.text(), 'user percent encoded') | ||
| } else { | ||
| t.fail('Response was undefined') | ||
| } | ||
| }) |
There was a problem hiding this comment.
Those test cases are introduced in #104. They are included in this PR as well to show nothing will be broken after this PR.
harrishancock
approved these changes
Jun 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR superseded #104 (and close #99 again).
In order to prevent Breaking Changes introduced in #100, the changes have been made:
ASSET_MANIFESTfirst, so user-encoded file will be served properlyASSET_MANIFEST, try decode URL then find again.pathIsEncodedas true.mapRequestToAssetmethod.The test cases added in #104 is also included in this PR as well, to show the Breaking Change has been avoided.
cc @EverlastingBugstopper @harrishancock