Add ability to search by --ray-id
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality used to be available via another legacy endpoint however it was deprecated[1] and removed in favour of a combination of the `/received` endpoint and `jq` magic due to some ongoing performance issues on the Cloudflare end. Thankfully, the ability to search by Ray ID has returned on a new dedicated endpoint[2] that hangs off the back of the `/received` route. In order to use this, I've updated the client and the CLI to accept the `--ray-id` parameter and build out the correct request. [1]: #14 (comment) [2]: https://api.cloudflare.com/#logs-recieved-logs-rayids
During the swap over period to using `/received` endpoint for ELS, there was a bit of logic that worked out (based on some CLI flags) which endpoint you intended to query. Internally, this used `byReceived` and `byRequest` however the legacy endpoint became deprecated and in #16, the default was set to use the `/received` endpoint. While most of the clean up has already been completed in other pull requests, I noticed these last few stragglers so I've wiped them out as they are no longer required.
|
Works great, and is extremely useful. 👍 |
|
cc @patryk - is this something you can get some eyes on internally? or point me in the direction of someone who can? |
|
Oh, sorry for late response, I might have miss the notification. I'll have a look on what's the maintenance status of the project. |
|
Much appreciated @patryk! |
|
Thanks for picking that up! Should be all good to go now. |
|
Thanks Jacob! Could you make sure the tests are passing? Seems like you still have some references to the old typoed pattern. |
|
🤦♂️ thanks @stephane-cloudflare. I just updated that last one and we're green again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality used to be available via another legacy endpoint
however it was deprecated and removed in favour of a combination of
the
/receivedendpoint andjqmagic due to some ongoing performanceissues with the Cloudflare ELS service.
Thankfully, the ability to search by Ray ID has returned on a new
dedicated endpoint that hangs off the back of the
/receivedroute.In order to use this, I've updated the client and the CLI to accept the
--ray-idparameter and build out the correct request.Included in this PR, but separate commit, is a bit of clean up around
the
byReceivedandbyRequestreferences since we no longer need totoggle between the two API routes and this was just left over debris
from other PRs.