Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add support for time ranges longer than one hour #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

edaemon
Copy link

@edaemon edaemon commented Nov 6, 2018

To address #36, this adds the --iterate option. With this option the range between the start and end time can be longer than the one hour limit imposed by the Logpull API, and each one-hour block of that range will be requested separately. Requests are delayed to account for the current API request rate limits.

I don't have any experience writing Go, so please let me know wherever there's something inelegant/strange/wrong.

@jacobbednarz
Copy link
Member

@edaemon do you mind getting CI green and I'll take a look at the code?

@edaemon
Copy link
Author

edaemon commented Nov 16, 2018

@jacobbednarz Sure, of course. I took care of the formatting issue so it's green for 1.9.x through tip, but I'll have to take a bit to look into the 1.7.x and 1.8.x issues.

@edaemon
Copy link
Author

edaemon commented Nov 20, 2018

@jacobbednarz This may just be my inexperience with Go showing, but from what I can tell the CI failures are in external packages. 1.7.x is failing in google.golang.org/api/transport/http/internal/propagation and 1.8.x seems to throw various warnings/failures from golang.org packages. I didn't make any changes related to any packages; I also noticed that the master branch build is failing with the same errors after #31 was merged.

Am I mistaken here or are these failures something external?

@jacobbednarz
Copy link
Member

I'll double check. Go 1.7/1.8 might not support/ship those anymore. We've dropped 1.7/1.8/1.9 in a couple of other repositories due to a similar issue.

@jacobbednarz
Copy link
Member

I've opened #38 to drop 1.7/1.8 from the build matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants