Implement JavaScript Rewriter API #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
commented
Jul 10, 2021
jyn514
reviewed
Jul 28, 2021
Comment on lines
+5
to
+36
| ```js | ||
| 'use strict'; | ||
|
|
||
| const { HTMLRewriter } = require('lol_html'); | ||
|
|
||
| const chunks = []; | ||
| const rewriter = new HTMLRewriter('utf8', (chunk) => { | ||
| chunks.push(chunk); | ||
| }); | ||
|
|
||
| rewriter.on('a[href]', { | ||
| element(el) { | ||
| const href = el | ||
| .getAttribute('href') | ||
| .replace('http:', 'https:'); | ||
| el.setAttribute('href', href); | ||
| }, | ||
| }); | ||
|
|
||
| [ | ||
| '<div><a href=', | ||
| 'http://example.com>', | ||
| '</a></div>', | ||
| ].forEach((part) => { | ||
| rewriter.write(Buffer.from(part)); | ||
| }); | ||
|
|
||
| rewriter.end(); | ||
|
|
||
| const output = Buffer.concat(chunks).toString('utf8'); | ||
| console.log(output); | ||
| ``` |
There was a problem hiding this comment.
Is this tested somewhere? I'm worried it will regress otherwise - maybe you could put it in examples/ and use include_str! from a doctest?
There was a problem hiding this comment.
i think ideally we should get some tests going with node but idk how to set that up with travis
devsnek
force-pushed
the
feature/js-api
branch
2 times, most recently
from
abac865
to
d8f27c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is mostly code from @inikulin