Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom wrangler.toml #14

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Custom wrangler.toml #14

merged 3 commits into from
Feb 26, 2024

Conversation

mackenly
Copy link
Contributor

Overview

Adds support for a third parameter to pass in the path to a custom wrangler.toml.

Behavior:

When a custom wrangler.toml is used...

  • The default template toml is ignored
  • The second name parameter is still used, overriding anything in the custom toml
  • The checks for adding a KV binding are ignored, since this is an advanced method and users are expected to have configured their own bindings (the primary use case for needing a custom toml)

When a custom wrangler.toml is not used..

  • Same behavior as before, no change

Issue

Closes #13

Copy link
Member

@jonnyparris jonnyparris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! 🙌🏾

@jonnyparris jonnyparris merged commit 242340f into cloudflare:main Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow custom wrangler.toml
2 participants