Add jest environment's missing dependencies #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasixKOR
force-pushed
the
chore/update-jest-deps
branch
from
8137302
to
da04ba6
Compare
mrbbot
reviewed
Mar 7, 2022
| @@ -45,7 +45,12 @@ | |||
| "@miniflare/sites": "2.3.0", | |||
| "@miniflare/storage-memory": "2.3.0", | |||
| "@miniflare/web-sockets": "2.3.0", | |||
| "miniflare": "2.3.0" | |||
| "miniflare": "2.3.0", | |||
| "@jest/environment": ">=27", | |||
There was a problem hiding this comment.
@jest/environment and @jest/types are only used in type-only imports, so should probably be devDependencies.
Comment on lines
+50
to
+53
| "@jest/fake-timers": ">=27", | ||
| "@jest/types": ">=27", | ||
| "jest-mock": ">=27", | ||
| "jest-util": ">=27" |
There was a problem hiding this comment.
I'm not too sure about this, but shouldn't these be peerDependencies instead, since we're expecting them to be installed by jest?
There was a problem hiding this comment.
Although I followed what Meta did on their jest-environment-node the package managers (including npm) doesn't treat the nested dependencies as peer dependencies (AFAIK).
mrbbot
added a commit
that referenced
this pull request
May 27, 2022
Co-authored-by: BasixKOR <basix@basix.tech>
|
Closing in favour of 120a672. This was easier than rebasing. 😅 Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! While I use this project with Yarn, I noticed the environment package has some unlisted dependencies. This will ensure the packages are installed correctly (like jest-environment-node) but also improves the compatibility with more strict package managers such as pnpm or Yarn Berry.