Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust for alarm storage #298

Merged
merged 5 commits into from
Jun 28, 2022
Merged

adjust for alarm storage #298

merged 5 commits into from
Jun 28, 2022

Conversation

CraigglesO
Copy link
Contributor

Fixes #297.

mrbbot
mrbbot suggested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! 👋 Thanks for fixing this. One tiny mutability concern then I'll merge. 🙂

packages/durable-objects/src/storage.ts Show resolved Hide resolved
packages/durable-objects/src/storage.ts Outdated Show resolved Hide resolved
@CraigglesO
Copy link
Contributor Author

Should be ready now. 😄

@mrbbot mrbbot merged commit 76bc1a6 into cloudflare:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbbot mrbbot mrbbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialisation error with storage.list() when an alarm is set
2 participants
@CraigglesO @mrbbot