Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type: "module" to vitest-environment-miniflare #661

Closed
wants to merge 2 commits into from

Conversation

Averethel
Copy link

fixes #645

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: 24cd376

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
vitest-environment-miniflare Patch
jest-environment-miniflare Patch
miniflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrbbot
Copy link
Contributor

mrbbot commented Aug 24, 2023

Hey! 👋 Thanks for this PR! Unfortunately, it looks like the tests are failing because AVA thinks it needs to load a CommonJS test as ESM because of "type": "module": https://github.com/cloudflare/miniflare/actions/runs/5876239805/job/15944739704?pr=661#step:5:1148 😕 I can try take a look at fixing this soon. Apologies for the delays in getting this fixed.

@Averethel
Copy link
Author

@mrbbot thank you! I was about to reach out for help.
I tried to figure it out independently, but I couldn't because of my lack of experience with the tooling.
Another approach I thought of (but couldn't explore) is some post-processing of the package.json in the build process. Not sure if your build pipeline supports it though

@mrbbot mrbbot closed this in 9f64855 Aug 25, 2023
@mrbbot
Copy link
Contributor

mrbbot commented Aug 25, 2023

Pushed a fix for this, will release soon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] vitest-environment-miniflare breaks when using vitest 0.34.1
2 participants