Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Miniflare 3] Use existing //# sourceURL comments if present #706

Merged
merged 1 commit into from Oct 5, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Oct 5, 2023

With Wrangler's new find_additional_modules support, there are cases where we'd like //# sourceURL not to be resolved from the module name/path. This change makes sure we don't insert this comment if it's already present, so Wrangler can add it.

With Wrangler's new `find_additional_modules` support, there are
cases where we'd like `//# sourceURL` not to be resolved from the
module name/path. This change makes sure we don't insert this
comment if it's already present, so Wrangler can add it.
@mrbbot mrbbot requested a review from a team October 5, 2023 15:43
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: fae588b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrbbot mrbbot merged commit d260585 into tre Oct 5, 2023
8 checks passed
@mrbbot mrbbot deleted the bcoll/tre-use-existing-source-url branch October 5, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants