[Miniflare 3] Add getFetcher() for dispatching fetch/scheduled/queue events
#708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds back support for dispatching `scheduled` and `queue` events directly. Miniflare 2 previously provided similar `dispatchScheduled()` and `dispatchQueue()` methods, but these implemented an inconsistent, non-standard API. With `getFetcher()`, we're able to reuse magic proxy code to support arbitrary Workers APIs. This is important for `queue()`, which supports sending any structured serialisable as a message `body`. `getFetcher()` also provides an idiomatic Miniflare API for dealing with multiple workers, matching that provided by `getBindings()`.
|
mrbbot
commented
Oct 5, 2023
mrbbot
commented
Oct 5, 2023
| compatibility flag to expose | ||
| [`scheduled()`](https://workers-types.pages.dev/experimental/#Fetcher.scheduled) | ||
| and [`queue()`](https://workers-types.pages.dev/experimental/#Fetcher.queue) | ||
| methods for dispatching `scheduled` and `queue` events. |
There was a problem hiding this comment.
Might be nice to add an example here, with a <details>.
penalosa
approved these changes
Oct 10, 2023
RamIdeas
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 馃憢 This change adds back support for dispatching
scheduledandqueueevents directly. Miniflare 2 previously provided similardispatchScheduled()anddispatchQueue()methods, but these implemented an inconsistent, non-standard API.With
getFetcher(), we're able to reuse magic proxy code to support arbitrary Workers APIs. This is important forqueue(), which supports sending any structured serialisable as a messagebody.getFetcher()also provides an idiomatic Miniflare API for dealing with multiple workers, matching that provided bygetBindings().