[Miniflare 3] Re-enable concurrent dispatchFetch()s and batch proxy heap frees
#713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to fix tests when adding the magic proxy, we restricted `dispatchFetch()` to one concurrent TCP connection. Unfortunately, this prevented long-lived `dispatchFetch()` requests. When proxies are garbage collected, we send a network request to `workerd` to free the corresponding entry in the `ProxyServer` heap. Garbage collection often happens in phases though, freeing lots of objects at once. This caused many concurrent requests to `workerd` (~60 in some tests), leading to many TCP connections being created. This change re-enables using multiple TCP connections, and attempts to address the root cause of the issues we were seeing, by batching frees before sending the network request.
mrbbot
force-pushed
the
bcoll/tre-concurrent-requests
branch
from
b7b2bf1
to
87f01cd
Compare
mrbbot
changed the title
dispatchFetch()s and batch proxy heap frees
RamIdeas
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix tests when adding the magic proxy, we restricted
dispatchFetch()to one concurrent TCP connection. Unfortunately, this prevented long-liveddispatchFetch()requests.When proxies are garbage collected, we send a network request to
workerdto free the corresponding entry in theProxyServerheap. Garbage collection often happens in phases though, freeing lots of objects at once. This caused many concurrent requests toworkerd(~60 in some tests), leading to many TCP connections being created.This change re-enables using multiple TCP connections, and attempts to address the root cause of the issues we were seeing, by batching frees before sending the network request.