Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add engines.node constraint #78

Merged
merged 2 commits into from
Oct 31, 2021
Merged

Conversation

lukeed
Copy link
Contributor

@lukeed lukeed commented Oct 31, 2021

Provides install-time Node version checks, preventing users with outdated/unsupported node versions from installing miniflare.

This 16.7 is the value reflected as of v2.0.0-next.1 & was confirmed by @mrbbot in conversation

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this to scripts/scaffold.mjs too, so newly generated packages also include it?

@lukeed
Copy link
Contributor Author

lukeed commented Oct 31, 2021

Ah sorry, hadn't looked at that script. Updated

@mrbbot mrbbot merged commit 2544354 into cloudflare:v2 Oct 31, 2021
@lukeed lukeed deleted the chore/engines branch October 31, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants