Merge 5682820 into 05d6303

cloudflare · Oct 17, 2019 · 47e6380 · 47e6380
2 parents 05d6303 + 5682820
commit 47e6380
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/posthtml-preload.js b/posthtml-preload.js
@@ -25,6 +25,7 @@ module.exports = function(options, foundEntries) {
         tag: 'script',
         attrs: {
           src: true,
+          nomodule: false,
         },
       });
     }

diff --git a/test/preload.js b/test/preload.js
@@ -121,7 +121,14 @@ describe('preload', function() {
           .expect(200, done);
       });
 
-      it('should create Link header for mutliple scripts', function(done) {
+      it('should ignore nomodule scripts', function(done) {
+        request(this.server)
+          .get('/blog/nomodule-script')
+          .expect('Content-Type', 'text/html; charset=utf-8')
+          .expect(200, done);
+      });
+
+      it('should create Link header for multiple scripts', function(done) {
         request(this.server)
           .get('/blog/multi-script')
           .expect('Content-Type', 'text/html; charset=utf-8')
@@ -425,6 +432,15 @@ function createServer(options) {
     },
   });
 
+  router.route('/blog/nomodule-script', {
+    GET: function(req, res) {
+      res.statusCode = 200;
+      res.setHeader('Content-Type', 'text/html; charset=utf-8');
+      res.write('<script src="/jquery.min.js" nomodule defer></script>');
+      res.end();
+    },
+  });
+
   router.route('/blog/multi-script', {
     GET: function(req, res) {
       res.statusCode = 200;