Skip to content
This repository has been archived by the owner on Oct 26, 2023. It is now read-only.

Include a server-side response nonce #11

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Include a server-side response nonce #11

merged 2 commits into from
Mar 2, 2021

Conversation

chris-wood
Copy link
Contributor

@coveralls
Copy link

coveralls commented Feb 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 593394484

  • 35 of 45 (77.78%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 74.952%
Changes Missing Coverage Covered Lines Changed/Added Lines %
odoh.go 35 45 77.78%
Totals Coverage Status
Change from base Build 591356616: -0.8%
Covered Lines: 392
Relevant Lines: 523
💛 - Coveralls

@chris-wood chris-wood changed the title Include a server-side response Include a server-side response nonce Feb 24, 2021
@tfpauly
Copy link

tfpauly commented Feb 24, 2021

Verified interop with my client. Ship it!

tanyav2
tanyav2 suggested changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@tanyav2 tanyav2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting approval for now, there is an interop issue that I'm investigating

@chris-wood chris-wood merged commit c36301d into master Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tanyav2 tanyav2 tanyav2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chris-wood @coveralls @tfpauly @tanyav2