feat: remove provisioners.Collection #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controller was creating an instance of a signing provisioner in the OriginIssuer reconciler, as an attempt to optimize against creating new API clients. As the certificates issued by the Origin API are valid for a minimium of 7 days this seems like a premature optimization. As the reconciler was not watching the service key secret for updates, it was also persisting stale API tokens. This changeset removes the concept of the provisioner collection. A new API client and provisioner will be created as needed in the OriginIssuer reconciler. This allows users to update their API token without needing to restart the controller. Fixes: ##109
cbroglie
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller was creating an instance of a signing provisioner in the OriginIssuer reconciler, as an attempt to optimize against creating new API clients. As the certificates issued by the Origin API are valid for a minimium of 7 days this seems like a premature optimization. As the reconciler was not watching the service key secret for updates, it was also persisting stale API tokens.
This changeset removes the concept of the provisioner collection. A new API client and provisioner will be created as needed in the OriginIssuer reconciler. This allows users to update their API token without needing to restart the controller.
Fixes: ##109