Add async_cleanup() method to ServerApp trait

cloudflare · Apr 9, 2024 · 58946a8 · 58946a8
1 parent acee67f
commit 58946a8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/pingora-core/src/apps/mod.rs b/pingora-core/src/apps/mod.rs
@@ -52,6 +52,11 @@ pub trait ServerApp {
 
     /// This callback will be called once after the service stops listening to its endpoints.
     fn cleanup(&self) {}
+
+    /// This callback will be called once after the service stops listening to its endpoints.
+    ///
+    /// Used for async cleanup tasks.
+    async fn async_cleanup(&self) {}
 }
 
 /// This trait defines the interface of an HTTP application.

diff --git a/pingora-core/src/services/listening.rs b/pingora-core/src/services/listening.rs
@@ -206,6 +206,7 @@ impl<A: ServerApp + Send + Sync + 'static> ServiceTrait for Service<A> {
         futures::future::join_all(handlers).await;
         self.listeners.cleanup();
         self.app_logic.cleanup();
+        self.app_logic.async_cleanup().await;
     }
 
     fn name(&self) -> &str {