Fixes #261 - Better Default
implementation for Opt
#272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@johnhurt Sorry about grabbing this, Github doesn’t notify me about issues being assigned, so I only noticed when I already had everything done. Feel free to close this if you have a fix ready.
This replaces the
Default
implementation forOpt
by an auto-generated one which happens to produce exactly the expected results (all boolean flags set tofalse
and configuration file toNone
) and none of the side-effects listed in #261.I checked and there is no piece of code in the repository (including tests and examples) actually depending on this
Default
implementation. So whatever the doc string is saying here, nothing was actually using it as an alias forOpt::parse
. Given that, I considered not creating an alternative for callingOpt::parse
without aclap::Parser
dependency the best course of action.