Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Allow query/series to be disabled for only some series, or special-case ALERTS{} #112

Closed
siebenmann opened this issue Jan 11, 2022 · 2 comments · Fixed by #113
Closed

Comments

@siebenmann
Copy link

We have some alert rules designed to detect large-scale issues and avoid flooding us with smaller alerts. As part of the alert rules, these alerts count active alerts using ALERTS{alertstate="firing"}. Normally we have no firing alerts, so when I run a pint check of our alert rules I get a query/series warning for this. I can disable this warning for the entire alert rule with # pint disable query/series, but the alert rule contains other series that I would like pint to check to make sure they exist. It would be nice if pint would either allow you to disable only a specific series in a rule instead of all of them, or alternately if it had a special case for the ALERTS series.

(Or perhaps there's already a way to do this.)

@prymitive
Copy link
Collaborator

The tricky bit is that there's very little that's "definitely wrong" in Prometheus world, a lot depends on intentions and given setup. That's the main reason checks like this simply print out results and let a human interpret these.
For now the only "definitely not incorrect" solution is to manually disable warnings for some selectors.

It's not currently possible but I've added support for it via #113 which will be in v0.6.5.
With that release you'll be able to add # pint disable query/series(ALERTS) or # pint disable query/series(ALERTS{alertstate="firing"}) comments that should disable checks for individual series.

@prymitive
Copy link
Collaborator

FYI ALERTS is handled better starting with v0.15 - https://cloudflare.github.io/pint/changelog.html#v0150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants