feat: Add lint cfg section handling include & exclude patterns #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Associated issue: #631 |
|
@prymitive curious if you have any thoughts? |
…Move CI config include & exclude validation logic into common code"
jburnitz
force-pushed
the
jb/add-lint-config
branch
from
ea3b6a6
to
2aabcc3
Compare
prymitive
requested changes
Apr 22, 2024
| @@ -0,0 +1,9 @@ | |||
| # This is an example config to be used when running pint as a linter | |||
|
|
|||
| lint { | |||
There was a problem hiding this comment.
I don't think I like the idea of having multiple include/exclude options, we'll end up with
ci { include = [...] }
lint { include = [...] }
watch { include = [...] }
all having same values.
If we were to have another place to add include/exclude then both options should be moved to parser {} and used for all commands.
There was a problem hiding this comment.
In that case, as a user, I'd expect an ability to inherit a base set of paths, then add other exclusions or inclusions on a command-by-command basis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow the
.pint.hclto support alintsection for statically defining what rule to analyze.Why
The CI command supports includes and excludes, but forces the concept of delta-to-another-branch.
This several scenarios this simply doesn't work:
Additionally, when using linting as part of pre-commit, tracking the paths to the rules in pre-commit config seems like a muddling of responsibilities (the rules paths is a pint configuration, not a pre-commit one)