You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation of the Client class is designed to handle a single request at a time. This design can be surprising/confusing and does not align with the convention used in the OPRF setup, which returns a tuple [finData, request].
Proposed Solution
Two possible ways to approach this refactoring:
Rename Client to TokenRequestContext to better convey the per-request state and update its methods accordingly.
Modify the createTokenRequest method to return a tuple [finData, request] instead of a single TokenRequest object.
It's proposed to refactor the Client class to adhere to the OPRF convention.
Description
The current implementation of the
Client
class is designed to handle a single request at a time. This design can be surprising/confusing and does not align with the convention used in the OPRF setup, which returns a tuple[finData, request]
.Proposed Solution
Two possible ways to approach this refactoring:
Client
toTokenRequestContext
to better convey the per-request state and update its methods accordingly.createTokenRequest
method to return a tuple[finData, request]
instead of a singleTokenRequest
object.It's proposed to refactor the
Client
class to adhere to the OPRF convention.or
The text was updated successfully, but these errors were encountered: