Skip to content

Commit

Permalink
Merge pull request #43 from cloudflare/keep_original_connect
Browse files Browse the repository at this point in the history
Allow usage of original connect method
  • Loading branch information
meddulla committed May 16, 2024
2 parents 433a4e7 + 3dba653 commit ee9a23b
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 6 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cloudflare/puppeteer",
"version": "0.0.7",
"version": "0.0.8",
"description": "A high-level API to control headless Chrome over the DevTools Protocol for use in Workers",
"keywords": [
"puppeteer",
Expand Down
23 changes: 20 additions & 3 deletions src/puppeteer-core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
// import {initializePuppeteer} from './initializePuppeteer.js';
import {Browser} from './common/Browser.js';
import {BrowserWorker} from './common/BrowserWorker.js';
import {Puppeteer} from './common/Puppeteer.js';
import {Puppeteer, ConnectOptions} from './common/Puppeteer.js';
import {WorkersWebSocketTransport} from './common/WorkersWebSocketTransport.js';

export * from './common/NetworkConditions.js';
Expand Down Expand Up @@ -195,12 +195,29 @@ class PuppeteerWorkers extends Puppeteer {
* @param sessionId - sessionId obtained from a .sessions() call
* @returns a browser instance
*/
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
public override async connect(
endpoint: BrowserWorker,
sessionId: string
): Promise<Browser>;

/**
* Establish a devtools connection to an existing session
*
* @param options - ConnectOptions
* @returns a browser instance
*/
public override async connect(options: ConnectOptions): Promise<Browser>;

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
public override async connect(
endpointOrOptions: BrowserWorker | ConnectOptions,
sessionId?: string
): Promise<Browser> {
if (!sessionId) {
return super.connect(endpointOrOptions as ConnectOptions);
}
const endpoint = endpointOrOptions as BrowserWorker;
try {
const transport = await WorkersWebSocketTransport.create(
endpoint,
Expand Down

0 comments on commit ee9a23b

Please sign in to comment.