Use Python3 print() syntax instead of Python2 print in README #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. You're right. The code was updated quite some time ago; however, the README wasn't. I'll get this merged soon. Thank you. |
joystein
reviewed
Oct 13, 2021
README.md
Outdated
| print zones.length() | ||
| print json.dumps(zones, indent=4, sort_keys=True) | ||
|
|
||
| zones.length() |
There was a problem hiding this comment.
Seems the print method got dropped for this line?
There was a problem hiding this comment.
Ah, must have missed this. Thanks ! Will fix ASAP
aioue
suggested changes
Feb 8, 2022
Co-authored-by: Tom Paine <github@aioue.net>
aioue
approved these changes
Feb 20, 2022
|
I pushed a new README which makes this a damn hard to merge - but it does fix the README print's. Thank you for pointing this out - sorry I didn't deal with it until too late to merge (it was an issue with .rst file from Makefile). |
mahtin
added a commit
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md and README.rst still use the old Python2
syntax which causes error when copy & pasting the code into Python3.
This PR changes the print syntax in README to use
Note that this syntax is fully compatible with recent versions of Python2 as well as all versions of Python3.