Skip to content

Commit

Permalink
ci: fix android build
Browse files Browse the repository at this point in the history
- A new cargo-ndk release requires Cargo.toml of a package, not a workspace.
- Current ubuntu image(22.04) already has NDK 25, use a builtin ndk instead
to remove warning and improve build time.
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md
  • Loading branch information
junhochoi authored and ghedo committed May 17, 2024
1 parent 273ba89 commit 3de33b9
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ jobs:
android_ndk_lts:
runs-on: ubuntu-latest
env:
NDK_LTS_VER: "25"
API_LEVEL: "21"
strategy:
matrix:
Expand Down Expand Up @@ -313,13 +312,5 @@ jobs:
- name: Install cargo-ndk
run: cargo install cargo-ndk

- name: Download NDK
run: curl --http1.1 -O https://dl.google.com/android/repository/android-ndk-r${{ env.NDK_LTS_VER }}-linux.zip

- name: Extract NDK
run: unzip -q android-ndk-r${{ env.NDK_LTS_VER }}-linux.zip

- name: Run cargo ndk
run: cargo ndk -t ${{ matrix.arch }} -p ${{ env.API_LEVEL }} -- build --verbose --features ffi
env:
ANDROID_NDK_HOME: ${{ github.workspace }}/android-ndk-r${{ env.NDK_LTS_VER }}
run: cargo ndk --manifest-path quiche/Cargo.toml -t ${{ matrix.arch }} -p ${{ env.API_LEVEL }} -- build --verbose --features ffi

0 comments on commit 3de33b9

Please sign in to comment.