-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit Congestion Notification support #1351
base: master
Are you sure you want to change the base?
Conversation
Just for the validation, we did a few runs on the Internet with a large file transfer (download of a 100 MB file). Here are attached some log snippets from the server's viewpoint. With plain ECT0 (no CE marking):
With ECT1 and a L4S network putting CE marks:
If needed, I can provide the full logs (not provided here given their size). |
This adds support for reporting incoming ECN counts via the "ECN Counts" field in ACK frames. Applications can report the ECN marking for incoming packets through the new `ecn` field of `RecvInfo`, and internally quiche will track the ECN counters, and creates ACK frames with the ECN Counts field. TODO: * Fetch ECN markings for incoming packets in apps.
TODO: * Set ECN markings for outgoing packets in apps. * Probe ECN for each path. * Validate ECN counts in ACKs.
811991c
to
a3a9bd5
Compare
This PR extends the commits of the WIP ECN PR (#1287) and addresses the remaining TODO points, namely the ACK ECN validation, the ECN path probing, and the actual ECN support to the apps
quiche-client
andquiche-server
.