Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix size_t printf type error. #94

Merged
merged 4 commits into from
Aug 8, 2019
Merged

Fix size_t printf type error. #94

merged 4 commits into from
Aug 8, 2019

Conversation

VMatrix1900
Copy link
Contributor

The type of stats.sent etc is size_t not uint64_t. We should use %zu to print them.

@VMatrix1900 VMatrix1900 requested a review from a team as a code owner August 4, 2019 08:57
@VMatrix1900 VMatrix1900 mentioned this pull request Aug 4, 2019
Closed
@ghedo
Copy link
Member

ghedo commented Aug 4, 2019

This was originally changed in https://github.com/cloudflare/quiche/pull/39/files#diff-938cb8b06341b6f8009f37feb42910dc to fix a build error on macOS, though I don't have the hardware to test this, @junhochoi can you have a look?

ghedo
ghedo requested changes Aug 4, 2019
View reviewed changes
examples/client.c Outdated Show resolved Hide resolved
@VMatrix1900 @ghedo
Update examples/client.c
657de9e 
Co-Authored-By: Alessandro Ghedini <alessandro@ghedini.me>
junhochoi
junhochoi previously approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@junhochoi junhochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

66a35f8 changed stats.recv and stats.sent and stats.lost from uint64_t to size_t, but this code was not updated.

I think this change is good.

@junhochoi
Copy link
Contributor

Also, need to update examples/http3-client.c same way.

@ghedo
Copy link
Member

ghedo commented Aug 6, 2019

Thanks @junhochoi.

@VMatrix1900 can you update the examples/http3-client.c file as well please?

ghedo
ghedo requested changes Aug 8, 2019
View reviewed changes
examples/http3-client.c Outdated Show resolved Hide resolved
@VMatrix1900 @ghedo
Update examples/http3-client.c
50065c2 
Co-Authored-By: Alessandro Ghedini <alessandro@ghedini.me>
@ghedo ghedo merged commit 5409f1a into cloudflare:master Aug 8, 2019
@ghedo
Copy link
Member

ghedo commented Aug 8, 2019

Merged, thanks @VMatrix1900!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghedo ghedo ghedo approved these changes

@junhochoi junhochoi junhochoi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VMatrix1900 @ghedo @junhochoi