kyle/keycache interface #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisom
force-pushed
the
kyle/keycache-interface
branch
from
6d7f33f
to
39d857d
Compare
Current coverage is 57.35% (diff: 59.89%)@@ master #160 diff @@
==========================================
Files 15 18 +3
Lines 2048 2216 +168
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1097 1271 +174
+ Misses 755 731 -24
- Partials 196 214 +18
|
kisom
force-pushed
the
kyle/keycache-interface
branch
from
39d857d
to
b37a19d
Compare
| } | ||
|
|
||
| // Refresh purges all expired or fully-used delegations in the | ||
| // crypto's key cache. It returns the number of delegations that |
There was a problem hiding this comment.
"It returns ..." sounds like describing c.cache.Refresh, I think the 2nd sentence can be removed?
kisom
force-pushed
the
kyle/keycache-interface
branch
2 times, most recently
from
f8c3ff5
to
70e1ebe
Compare
| } | ||
|
|
||
| access := AccessStructure{ | ||
| Names: persistUsers, |
There was a problem hiding this comment.
hmm, I probably missed something, this is a single user array, shall it come from the persist policy?
There was a problem hiding this comment.
Good catch, fixed.
kisom
force-pushed
the
kyle/keycache-interface
branch
from
70e1ebe
to
84d30a5
Compare
|
|
||
| var ( | ||
| persistLabels = []string{"restore"} | ||
| persistUsers = []string{"restore"} |
There was a problem hiding this comment.
so we can remove this now right?
kisom
force-pushed
the
kyle/keycache-interface
branch
from
84d30a5
to
15a8126
Compare
|
LGTM |
This is a rather large change. It consists of the following changes: + Direct access to the keycache has been removed from the core package. This forces all interaction with the cache to go through the Cryptor, which is required for persistence. The Cryptor needs to know when the cache has changed, and the only way to do this effectively is to make the Cryptor responsible for managing the keycache. + A new persist package has been added. This provides a Store interface, for which two implementations are provided. The first is a null persister: this is used when no persistence is configured. The second is a file-backed persistence store. + The Cryptor now persists the cache every time it changes. Additionally, a number of missing returns in a function in the core package have been added.
kisom
force-pushed
the
kyle/keycache-interface
branch
from
15a8126
to
7c95007
Compare
| return c.cache.DelegateStatus(name, labels, admins) | ||
| } | ||
|
|
||
| var persistLabels = []string{"restore"} |
There was a problem hiding this comment.
It seems awkward to have this as a global in something other than the package it belongs to. Would it not make more sense for it to be exported from redoctober/persist?
I realize it's nitpicky, but it's already hard enough to understand what is persist and what is cryptor. Feel free to ignore unless you're opening another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a file-backed persistence store.
This is a rather large change. It consists of the following changes:
Additionally, a number of missing returns in a function in the core package have been added.