Merge pull request #1723 from Shopify/empty-filter

Handle missing/empty filter in terraform
cloudflare · Jun 27, 2022 · 3d37ffb · 3d37ffb
2 parents f9b8260 + c65d96b
commit 3d37ffb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.changelog/1723.txt b/.changelog/1723.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/cloudflare_logpush_job: fix unmarhalling job with empty/no filter
+```
diff --git a/internal/provider/resource_cloudflare_logpush_job.go b/internal/provider/resource_cloudflare_logpush_job.go
@@ -72,7 +72,7 @@ func getJobFromResource(d *schema.ResourceData) (cloudflare.LogpushJob, *AccessI
 	}
 
 	filter := d.Get("filter")
-	if filter != nil {
+	if filter != "" {
 		var jobFilter cloudflare.LogpushJobFilters
 		if err := json.Unmarshal([]byte(filter.(string)), &jobFilter); err != nil {
 			return cloudflare.LogpushJob{}, identifier, err