Suppress session_duration diffs for bookmark applications

cloudflare · Dec 7, 2022 · 5e095a4 · 5e095a4
1 parent 24ed3d8
commit 5e095a4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/.changelog/2076.txt b/.changelog/2076.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/access_application: fix issue where session_duration always showed a diff for bookmark apps
+```
diff --git a/internal/provider/schema_cloudflare_access_application.go b/internal/provider/schema_cloudflare_access_application.go
@@ -53,6 +53,16 @@ func resourceCloudflareAccessApplicationSchema() map[string]*schema.Schema {
 			Type:     schema.TypeString,
 			Optional: true,
 			Default:  "24h",
+			DiffSuppressFunc: func(k, oldValue, newValue string, d *schema.ResourceData) bool {
+				appType := d.Get("type").(string)
+				// Suppress the diff if it's a bookmark app type. Bookmarks don't have a session duration
+				// field which always creates a diff because of the default '24h' value.
+				if appType == "bookmark" {
+					return true
+				}
+
+				return oldValue == newValue
+			},
 			ValidateFunc: func(val interface{}, key string) (warns []string, errs []error) {
 				v := val.(string)
 				_, err := time.ParseDuration(v)