remove commented out code

cloudflare · Jan 10, 2023 · b6896ce · b6896ce
1 parent b54bfb9
commit b6896ce
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 26 deletions.
diff --git a/internal/provider/resource_cloudflare_pages_project.go b/internal/provider/resource_cloudflare_pages_project.go
@@ -47,16 +47,6 @@ func buildDeploymentConfig(environment interface{}) cloudflare.PagesProjectDeplo
 			}
 
 			break
-		//case "secret":
-		//	for _, variable := range value.(*schema.Set).List() {
-		//		data := variable.(map[string]interface{})
-		//		envVar := cloudflare.EnvironmentVariable{
-		//			Value: data["text"].(string),
-		//			Type:  cloudflare.SecretText,
-		//		}
-		//		deploymentVariables[data["name"].(string)] = &envVar
-		//	}
-		//	break
 		case "kv_namespaces":
 			namespace := cloudflare.NamespaceBindingMap{}
 			variables := value.(map[string]interface{})
@@ -139,15 +129,8 @@ func parseDeploymentConfig(deployment cloudflare.PagesProjectDeploymentConfigEnv
 		if value.Type == cloudflare.PlainText {
 			deploymentVars[key] = value.Value
 		}
-		//} else {
-		//	secretsBinding.Add(map[string]interface{}{
-		//		"name": key,
-		//		"text": value.Value,
-		//	})
-		//}
 	}
 	config["environment_variables"] = deploymentVars
-	//config["secret"] = secretsBinding
 
 	deploymentVars = map[string]string{}
 	for key, value := range deployment.KvNamespaces {

diff --git a/internal/provider/resource_cloudflare_pages_project_test.go b/internal/provider/resource_cloudflare_pages_project_test.go
@@ -63,7 +63,7 @@ func testPagesProjectBuildConfig(resourceID, accountID string) string {
 			web_analytics_tag = "cee1c73f6e4743d0b5e6bb1a0bcaabcc"
 			web_analytics_token = "021e1057c18547eca7b79f2516f06o7x"
 		  }
-		  %[4]s	
+		  %[4]s
 		}
 		`, resourceID, accountID, resourceID, testPagesProjectEmptyDeploymentConfig)
 }
@@ -145,13 +145,13 @@ func testPagesProjectDirectUpload(resourceID, accountID string) string {
 		  account_id = "%[2]s"
 		  name = "%[1]s"
 		  production_branch = "main"
-		 %[3]s	
+		 %[3]s
 		}
 		`, resourceID, accountID, testPagesProjectEmptyDeploymentConfig)
 }
 
 func TestAccCloudflarePagesProject_Basic(t *testing.T) {
-	//t.Skip("Skipping Pages acceptance tests pending investigation into automating the setup and teardown")
+	t.Skip("Skipping Pages acceptance tests pending investigation into automating the setup and teardown")
 
 	rnd := generateRandomResourceName()
 	name := "cloudflare_pages_project." + rnd

diff --git a/internal/provider/schema_cloudflare_pages_project.go b/internal/provider/schema_cloudflare_pages_project.go
@@ -119,12 +119,6 @@ func resourceCloudflarePagesProjectSchema() map[string]*schema.Schema {
 				Description: "Environment variables for Pages Functions.",
 				Optional:    true,
 			},
-			//"secret": {
-			//	Type:        schema.TypeSet,
-			//	Description: "Secrets for Pages Functions.",
-			//	Optional:    true,
-			//	Elem:        secretTextBindingResource,
-			//},
 			"kv_namespaces": {
 				Type:        schema.TypeMap,
 				Description: "KV namespaces used for Pages Functions.",