Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: resource/cloudflare_access_group: supports ip_list property. #2073

Merged
merged 3 commits into from Jan 18, 2023
Merged

feat: resource/cloudflare_access_group: supports ip_list property. #2073

merged 3 commits into from Jan 18, 2023

Conversation

keitap
Copy link
Contributor

@keitap keitap commented Dec 3, 2022

Add support ip_list property to cloudflare_access_group resource.

Fixes #1665

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022 •
edited

changelog detected ✅

@keitap
Copy link
Contributor Author

keitap commented Dec 12, 2022

@jacobbednarz If not satisfied any requirements, let me know.

@keitap
resource/cloudflare_access_group: supports ip_list property.
163f76d 
Signed-off-by: keita <keitap@gmail.com>
@keitap
adds changelog file.
fa6dfbb 
Signed-off-by: keita <keitap@gmail.com>
@jacobbednarz jacobbednarz added workflow/pending-cloudflare-response Indicates an issue or PR requires a response from the Cloudflare team. workflow/pending-public-documentation Indicates an issue or PR requires changes to public documentation confirming suitability for use. labels Dec 27, 2022
@jacobbednarz
Copy link
Member

@Justin-Holmes i can't find any public docs for ip_list. can you please confirm stability and suitability for inclusion here?

@Justin-Holmes
Copy link
Contributor

@jacobbednarz This is stable and good for inclusion here, just an oversight on our part. We'll add this to our API documentation.

@jacobbednarz
Copy link
Member

the access team have the docs in the pipelines so we're 👍 to merge this one.

acceptance tests are passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareAccessGroupConfig_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareAccessGroupConfig_BasicZone
--- PASS: TestAccCloudflareAccessGroupConfig_BasicZone (17.51s)
=== RUN   TestAccCloudflareAccessGroupConfig_BasicAccount
--- PASS: TestAccCloudflareAccessGroupConfig_BasicAccount (16.19s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	34.190s

@jacobbednarz jacobbednarz merged commit 81ad0c4 into cloudflare:master Jan 18, 2023
@github-actions github-actions bot added this to the v3.33.0 milestone Jan 18, 2023
github-actions bot pushed a commit that referenced this pull request Jan 18, 2023
Update CHANGELOG.md for #2073
dba8e57
@keitap keitap deleted the access_group_ip_list branch January 18, 2023 06:36
@github-actions
Copy link
Contributor

This functionality has been released in v3.33.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
workflow/pending-cloudflare-response Indicates an issue or PR requires a response from the Cloudflare team. workflow/pending-public-documentation Indicates an issue or PR requires changes to public documentation confirming suitability for use.
Projects
None yet
Milestone
v3.33.0
Development

Successfully merging this pull request may close these issues.

cloudflare_access_group: reference ip list in include statement
3 participants
@keitap @jacobbednarz @Justin-Holmes