upgrade to cloudflare-go to v0.14.0 #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
force-pushed
the
make-0.14.0-compatible
branch
from
9fd65a2
to
9e95063
Compare
this schema migration was added in 2014 for migrating Cloudflare records from the old format to align with the V4 API and it has an assumption that only a single request will be made in sequence. This is no longer true and spending the time on fixing the test is a waste of time given no one should be upgrading from a 7 year old schema.
jacobbednarz
force-pushed
the
make-0.14.0-compatible
branch
2 times, most recently
from
7f08a7c
to
026ff79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the version of
cloudflare-goin use to be 0.14 and addresses the backwards incompatible changes.Closes #959
Closes #943