Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS record name validation improvements #1740

Merged
merged 4 commits into from
Jul 1, 2022
Merged

DNS record name validation improvements #1740

merged 4 commits into from
Jul 1, 2022

Commits on Jun 30, 2022

  1. Rename validateRecordName to validateRecordContent

    @janik-cloudflare
    janik-cloudflare committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    db61274 View commit details
    Browse the repository at this point in the history

  2. Ensure DNS record names are non-empty

    @janik-cloudflare
    janik-cloudflare committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    f5c9ae6 View commit details
    Browse the repository at this point in the history

  3. fix MX record test assertions

    @jacobbednarz
    jacobbednarz committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    f36a59f View commit details
    Browse the repository at this point in the history

  4. resource/cloudflare_record: fix missing record handler 

    The API has changed the error response and was previously relying on the
string in the API response to determine when to remove it. Swapping over
to using `*cloudflare.NotFoundError` now that it exists.

Closes #1621
    @jacobbednarz
    jacobbednarz committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    8330be8 View commit details
    Browse the repository at this point in the history