Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default values for redirect list updates. #1746

Conversation

orium
Copy link
Member

@orium orium commented Jun 30, 2022

No description provided.

@orium orium requested a review from jacobbednarz as a code owner June 30, 2022 17:17
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2022

changelog detected ✅

@orium orium force-pushed the dsousa/FLPROD-397-fix-redirect-update-default-values branch from be5dd62 to 27f68d1 Compare June 30, 2022 17:19
@orium orium force-pushed the dsousa/FLPROD-397-fix-redirect-update-default-values branch from 27f68d1 to 2d6305a Compare July 4, 2022 15:08
@jacobbednarz
Copy link
Member

i'm having a look through this PR and would supplying false as the default solve the issue here? also, i don't think the latest commit actually solves this as it is still a boolean - for the workaround to work (heh), we'll likely need a string that allows "enabled"/"disabled"/"" as the values.

@orium orium force-pushed the dsousa/FLPROD-397-fix-redirect-update-default-values branch from 2d6305a to 6edac68 Compare July 4, 2022 22:43
@orium orium force-pushed the dsousa/FLPROD-397-fix-redirect-update-default-values branch from 6edac68 to 18ebea8 Compare July 5, 2022 08:45
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to update the descriptions and re-run make docs and we're good!

internal/provider/schema_cloudflare_list.go Outdated Show resolved Hide resolved
internal/provider/schema_cloudflare_list.go Outdated Show resolved Hide resolved
internal/provider/schema_cloudflare_list.go Outdated Show resolved Hide resolved
internal/provider/schema_cloudflare_list.go Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

acceptance tests are all passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareList_" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccCloudflareList_Exists
--- PASS: TestAccCloudflareList_Exists (10.63s)
=== RUN   TestAccCloudflareList_UpdateDescription
--- PASS: TestAccCloudflareList_UpdateDescription (18.67s)
=== RUN   TestAccCloudflareList_Update
--- PASS: TestAccCloudflareList_Update (49.49s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   79.346s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check      [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

@jacobbednarz jacobbednarz merged commit 772767e into cloudflare:master Jul 7, 2022
@github-actions github-actions bot added this to the v3.19.0 milestone Jul 7, 2022
github-actions bot pushed a commit that referenced this pull request Jul 7, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.19.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants