Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_origin_ca_certificate: trigger a replacement when csr is changed #2055

Merged
merged 2 commits into from Nov 25, 2022

Conversation

peruzzof
Copy link
Contributor

@peruzzof peruzzof commented Nov 24, 2022

As commented in the #1007, this is the proposed fix.
I ran some tests with the provided terraform and it works as expected

Closes #1007

@github-actions
Copy link
Contributor

changelog detected ✅

@peruzzof
Copy link
Contributor Author

peruzzof commented Nov 24, 2022

Just a note that most probably the Update function that was removed per error during the test must return after the change in the #2048 . So after you approve one I will need to check the second one

@jacobbednarz jacobbednarz merged commit 2903925 into cloudflare:master Nov 25, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Nov 25, 2022
@jacobbednarz
Copy link
Member

thanks @peruzzof. for the UpdateContext method, i would say we'll need to leave it in place but only update the methods we expect to change without a new resource being created.

github-actions bot pushed a commit that referenced this pull request Nov 25, 2022
@peruzzof peruzzof deleted the csr-forcenew branch November 25, 2022 10:33
@github-actions
Copy link
Contributor

This functionality has been released in v3.29.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan including changes to cloudflare_origin_ca_certificate do not taint certificate_body
2 participants