Don't require edge_ttl.default in cache rules #2080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `default` is required, but not _allowed_ to be set when `mode` is set to `respect_origin`. I believe it should be optional; we'll still get an error when _not_ setting this in combination with mode `override_origin`. Closes cloudflare#2007
|
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md. Example: If you do not require a release note to be included, please add the |
jacobbednarz
requested changes
Dec 11, 2022
|
superseded by #2097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
defaultis required, but not allowed to be set whenmodeis set torespect_origin. I believe it should be optional; we'll still get an error when not setting this in combination with modeoverride_origin.Closes #2007