Fix multiple emails in notification policy

[Qantas94Heavy]

Setting data["id"] only saves the last value as it keeps writing to the same map. Instead a new map should be created for each value.

Fixes: #1917

[github-actions]

changelog detected ✅

[jacobbednarz]

thanks for this @Qantas94Heavy. can you please add an acceptance test that will demonstrate this fixes the issue?

[jacobbednarz]

acceptance tests all looking good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareNotificationPolicy_" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareNotificationPolicy_Basic
--- PASS: TestAccCloudflareNotificationPolicy_Basic (26.83s)
=== RUN   TestAccCloudflareNotificationPolicy_WithFiltersAttribute
--- PASS: TestAccCloudflareNotificationPolicy_WithFiltersAttribute (24.59s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	52.330s

thanks @Qantas94Heavy 💯

[github-actions]

This functionality has been released in v4.1.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!