Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add import cloudflare_tunnel_config #2298

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

yktakaha4
Copy link
Contributor

Thanks for the great OSS.

I am using cloudflare_tunnel_config in production.
I have added implementation and documentation to import existing resources.

Implemented with reference to cloudflare_tunnel.

$ TESTARGS='-run "TestAccCloudflareTunnelConfig" -count 1 -parallel 1' make testacc
TF_ACC=1 go test $(go list ./...) -v -run "TestAccCloudflareTunnelConfig" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/internal/acctest    [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/internal/consts     [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/internal/framework/expanders        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/internal/framework/flatteners       [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/internal/framework/modifiers/defaults       [no test files]
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/provider 0.007s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/example  0.003s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/rulesets 0.008s [no tests to run]
=== RUN   TestAccCloudflareTunnelConfig_Full
--- PASS: TestAccCloudflareTunnelConfig_Full (15.17s)
=== RUN   TestAccCloudflareTunnelConfig_Short
--- PASS: TestAccCloudflareTunnelConfig_Short (14.48s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider      29.656s
?       github.com/cloudflare/terraform-provider-cloudflare/internal/utils      [no test files]

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

changelog detected ✅

@yktakaha4 yktakaha4 marked this pull request as ready for review March 17, 2023 13:09
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! we're almost there however, we need to fix the import documentation otherwise it will be overwritten next time someone merges and the documentation is regenerated. once that is addressed, we're good to merge here.

@jacobbednarz
Copy link
Member

acceptance tests all looking good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTunnelConfig_" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTunnelConfig_Full
--- PASS: TestAccCloudflareTunnelConfig_Full (21.10s)
=== RUN   TestAccCloudflareTunnelConfig_Short
--- PASS: TestAccCloudflareTunnelConfig_Short (24.96s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	46.976s

thanks a bunch @yktakaha4 🏆

@jacobbednarz jacobbednarz merged commit 546792f into cloudflare:master Mar 20, 2023
@github-actions github-actions bot added this to the v4.2.0 milestone Mar 20, 2023
github-actions bot pushed a commit that referenced this pull request Mar 20, 2023
@yktakaha4
Copy link
Contributor Author

Thanks for the fix and merge!
I will be careful next time.

rwhelan pushed a commit to rwhelan/terraform-provider-cloudflare that referenced this pull request Mar 20, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.2.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants