Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for new prop path_cookie_attribute on Access Applications #2385

Conversation

AkemiDavisson
Copy link
Contributor

Requires upstream PR before merge: cloudflare/cloudflare-go#1223

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

changelog detected ✅

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Apr 19, 2023
@jacobbednarz
Copy link
Member

looks like this has caused a regression

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccessApplication_" -timeout 120m -parallel 1
go: downloading github.com/cloudflare/cloudflare-go v0.66.0
=== RUN   TestAccCloudflareAccessApplication_BasicZone
panic: interface conversion: interface {} is nil, not bool

goroutine 261 [running]:
github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider.resourceCloudflareAccessApplicationCreate({0x1f60e68, 0xc0005a2300}, 0x0?, {0x1d70ae0?, 0xc0005d80c0?})
	/Users/jacob/go/src/github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider/resource_cloudflare_access_application.go:51 +0xea5
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).create(0xc000831180, {0x1f60ea0, 0xc0004a28a0}, 0xd?, {0x1d70ae0, 0xc0005d80c0})
	/Users/jacob/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/resource.go:707 +0x12e
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0xc000831180, {0x1f60ea0, 0xc0004a28a0}, 0xc00011a1a0, 0xc00044da00, {0x1d70ae0, 0xc0005d80c0})
	/Users/jacob/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/resource.go:837 +0xa85
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ApplyResourceChange(0xc000011098, {0x1f60ea0?, 0xc0004a27e0?}, 0xc000425db0)
	/Users/jacob/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/grpc_provider.go:1021 +0xe8d
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ApplyResourceChange(0xc00013cfa0, {0x1f60ea0?, 0xc0002d1dd0?}, 0xc0005a08c0)
	/Users/jacob/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.15.0/tfprotov5/tf5server/server.go:818 +0x574
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ApplyResourceChange_Handler({0x1d37f60?, 0xc00013cfa0}, {0x1f60ea0, 0xc0002d1dd0}, 0xc0005a0850, 0x0)
	/Users/jacob/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.15.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:419 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0000fe000, {0x1f650b8, 0xc000603040}, 0xc00031bc20, 0xc000429590, 0x26335e0, 0x0)
	/Users/jacob/go/pkg/mod/google.golang.org/grpc@v1.54.0/server.go:1345 +0xdf3
google.golang.org/grpc.(*Server).handleStream(0xc0000fe000, {0x1f650b8, 0xc000603040}, 0xc00031bc20, 0x0)
	/Users/jacob/go/pkg/mod/google.golang.org/grpc@v1.54.0/server.go:1722 +0xa36
google.golang.org/grpc.(*Server).serveStreams.func1.2()
	/Users/jacob/go/pkg/mod/google.golang.org/grpc@v1.54.0/server.go:966 +0x98
created by google.golang.org/grpc.(*Server).serveStreams.func1
	/Users/jacob/go/pkg/mod/google.golang.org/grpc@v1.54.0/server.go:964 +0x28a
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	8.360s
FAIL
make: *** [testacc] Error 1

@jacobbednarz
Copy link
Member

closing due to going stale and now being a rather beyond master. feel free to reopen if this gets traction again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants