Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing #165

Open
kriskwiatkowski opened this issue Apr 5, 2019 · 3 comments
Open

Improve testing #165

kriskwiatkowski opened this issue Apr 5, 2019 · 3 comments

Comments

@kriskwiatkowski
Copy link
Contributor

kriskwiatkowski commented Apr 5, 2019

I would like to collect here ideas on how to improve testing. This is my current non-exhaustive list

  • run tests the library against multiple versions of Go
  • run tests the library against multiple versions of platform (amd64, arm, arm64 and on linux, windows and macOS). We should run those tests for all platforms we declare to support
  • Introduce code coverage
  • Use go-fuzz for fuzzing GH Implement fuzz testing #65
  • Use only one docker container for interoperability testing: GH testing: one docker for testing is (more than) enough #157
  • Build debian package - mainly to ensure any change to Makefile won't break Cloudflare's internal build. Also it would be great to be able to install go with tris from a package
  • Introduce code coverage
  • Benchmarking, to ensure there is no performance degradation (if that's possible)
  • Can we do symbolic execution with something which has similar functionality to KLEE?
@kriskwiatkowski kriskwiatkowski changed the title Test against multiple Go releases Improve testing Apr 5, 2019
@Lekensteyn
Copy link
Contributor

Right now it does not build on macOS due to issues in the Makefile with sed and cp, I'm working on that.

However it also seems that 1.12 moved some packages since chacha20poly1305 is no longer under a golang_org folder. Compare 1.12.1 on macOS:
/usr/local/Cellar/go/1.12.1/libexec/src/internal/x/crypto/chacha20poly1305
/usr/share/go-1.12/src/internal/x/crypto/chacha20poly1305 (golang-1.12-src in Debian sid)

to go 1.11.6:
/usr/share/go-1.11/src/vendor/golang_org/x/crypto/chacha20poly1305

@kriskwiatkowski
Copy link
Contributor Author

kriskwiatkowski commented Apr 9, 2019

Thanks for reporting ! I don't think it has ever been tested with 1.12

@Lekensteyn
Copy link
Contributor

I have opened #166 to track the Go 1.12 issue. Go 1.13 has changed things again, possibly due to Go modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants