Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

We'll get a panic if user sets zero or negative TTL value, add a check #140

Merged
merged 1 commit into from Jul 10, 2017
Merged

We'll get a panic if user sets zero or negative TTL value, add a check #140

merged 1 commit into from Jul 10, 2017

Conversation

prymitive
Copy link
Contributor

No description provided.

@prymitive prymitive added the bug label Jul 9, 2017
@prymitive prymitive requested review from Tenzer and jamesog July 9, 2017 15:31
@Tenzer
Copy link

Tenzer commented Jul 10, 2017

Do we have a check if the provided TTL is a number at all?

@prymitive
Copy link
Contributor Author

It's time.Duration string, not a number, and it's validated

Tenzer
Tenzer approved these changes Jul 10, 2017
View reviewed changes
Copy link

@Tenzer Tenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, cool.

@prymitive prymitive merged commit 6c74a7b into master Jul 10, 2017
@prymitive prymitive deleted the min-ttls branch July 10, 2017 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tenzer Tenzer Tenzer approved these changes

@jamesog jamesog Awaiting requested review from jamesog

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prymitive @Tenzer