This repository has been archived by the owner on Jul 22, 2020. It is now read-only.
Mapper package refactoring #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terinjokes
approved these changes
Jan 22, 2018
Mapper should only take input, decode it and map onto internal model instances
With this change we'll initialize Transport object for each Alertmanager and just call Read() on it when we need to use this transport to read from upstream Alertmanager
Fix bugs, add docstrings and let each mapper give us full url since it doesn't handle any http requests now (it just maps text to objects now)
Not used
prymitive
force-pushed
the
mapper-refactor
branch
from
46c3d28
to
c7fb8db
Compare
prymitive
added a commit
that referenced
this pull request
Jan 25, 2018
Alertmanager 0.4.x silences endpoint uses pagination, code for this was incorrectly dropped in #216, re-add it. Requires a way for mapper packages to signal the need for passing query args to HTTP requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address comment from #207 some cleanups are needed, mostly around responsibilities of each sub-package, which this PR aims to resolve.
mapperis now aAlertmanager API response body->unsee objectsmapping code, which I think makes more sense, and it doesn't do any request handling anymoretransportwas refactored to allow passing it to theAlertmanagerinstance (which we create for each AM upstream), so we no longer need to pass timeouts or tls.Config around.This is 90% done, need to re-read changes here and likely cleanup a few things