This repository has been archived by the owner on Jul 22, 2020. It is now read-only.
Polish silence form UI #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop separators and replace submit button text with an icon
jshint needs to be added to 'make lint' target eventually, let's start with fixing some of the warnings it's generating
Move it to the right place, having it in silenceFormCalculateDuration means that we can trigger recursive updates
With this the user is able to reset duration to minimum by clickin on the day button when only 1 hour duration is set
This makes it more consistien when user resets the duration to the minimum of 1 minute
This isn't used by anything
bobrik
approved these changes
Apr 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a list of small glitches I've noticed in the silence form as I was using it.
It also removes some elements (like separators) to make it cleaner.
Plus some fixes for warnings reported by jshint (style issues, missing
;, nothing serious).