Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix federation with Pleroma (take 2) #314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexgleason
Copy link

Supersedes #313, but I wanted to make a separate PR so the solutions could be easily compared. See the original for more context.

Pleroma has a bug where (created) is not an acceptable component to sign. This leads to a conundrum, because Date is a "forbidden" header name according to the fetch spec.

At the same time, Mastodon requires that Date or (created) be part of the signature. So if you choose (created), federation with Pleroma breaks. If you choose Date, you violate the fetch spec.

Trying to set (created) as an actual header throws. But setting Date and removing (created) actually works.

I am running this code in Deno, not a Cloudflare worker. There I am able to set the Date header just fine, and federation works perfectly with Mastodon, Pleroma, and Misskey. I tested all 3 this time.

@xtuc
Copy link
Member

xtuc commented Feb 20, 2023

@alexgleason are you runing wildebeest in Deno or just some code?

@edevil
Copy link
Contributor

edevil commented Feb 20, 2023

Has the Pleroma bug been reported? It seems it would make more sense to fix that.

@alexgleason
Copy link
Author

Has the Pleroma bug been reported? It seems it would make more sense to fix that.

The http_signatures library is hosted on Pleroma's closed GitLab. It's not possible to open an issue. Furthermore Pleroma releases come about once per year at the current rate, so it's much more likely to be fixed on the Wildebeest end. Even then hundreds of Pleroma servers won't update.

are you runing wildebeest in Deno or just some code?

I'm running the same code in a Deno custom ActivityPub server. It needs to be verified that a CF Worker can set the Date header. But if federation with Mastodon still works after this change, Pleroma should work as well.

shuymn added a commit to shuymn/wildebeest that referenced this pull request Jul 29, 2023
@vpzomtrrfrt
Copy link

Yes, it would be nice if Pleroma supported the newer spec, but they're far from the only ones, and most implementations seem to send Date to maximize compatibility: https://arewehs2019yet.vpzom.click/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants