crypto: remove webcrypto EdDSA key checks and properties #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
jasnell
reviewed
Aug 30, 2023
| @@ -2126,9 +2117,6 @@ private: | |||
| jwk.kty = kj::str("OKP"); | |||
| jwk.crv = kj::str(getAlgorithmName() == "X25519"_kj ? "X25519"_kj : "Ed25519"_kj); | |||
| jwk.x = kj::encodeBase64Url(kj::arrayPtr(rawPublicKey, publicKeyLen)); | |||
| if (getAlgorithmName() == "Ed25519"_kj) { | |||
| jwk.alg = kj::str("EdDSA"); | |||
| } | |||
There was a problem hiding this comment.
There's a chance this could end up being a breaking change. Will need to determine if a compatibility flag is necessary on this particular bit.
There was a problem hiding this comment.
Cool, by all means please take this effort over, my hope here was merely to bring this to your attention ;)
This was referenced Oct 4, 2023
|
I've deleted my fork so this PR automatically closed, i'm assuming you'll take this over @jasnell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per WICG/webcrypto-secure-curves#24 this removes the check for Ed25519 JWK
algduring importKey and removes thealgfor Ed25519 keys during JWK exportKey.