Implement AbortSignal.protototype.onabort #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/ew-8235-abortsignal-onabort
branch
from
1e059c8
to
b1fb4c1
Compare
kentonv
reviewed
Mar 16, 2024
kentonv
approved these changes
Mar 20, 2024
IgorMinar
approved these changes
Mar 21, 2024
jasnell
force-pushed
the
jsnell/ew-8235-abortsignal-onabort
branch
2 times, most recently
from
8c81fee
to
bce8e35
Compare
The spec defines `onabort` as a prototype property, implement it as such
jasnell
force-pushed
the
jsnell/ew-8235-abortsignal-onabort
branch
from
f94708e
to
0500904
Compare
|
I'm not going to do it in this PR, but I think because this pattern is common to all whatwg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec defines
onabortas a prototype property, implement it as such.Technically speaking, this could be considered a breaking change :-/ ... I'm hoping we can get away with it without requiring a compat flag. It's a potentially breaking change because prior to this, the following operations would have different results:
'onabort' in AbortSignal.prototype... previously, false, now truedelete signal.onabort... previously deletes the own property if set, now has no changeObject.keys(signal)... previously would includeonabortif it was set, now always excludes itOne thing this PR doesn't do (that we can do later in a separate PR) is define the type mapping override for
onabort.