Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release docs #1924

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Update Release docs #1924

merged 1 commit into from
Mar 29, 2024

Conversation

Warfields
Copy link
Contributor

Added explanation on why release actions are done on main, not on the release tag.

@Warfields Warfields requested review from a team as code owners March 29, 2024 16:26
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@fhanau
Copy link
Collaborator

fhanau commented Mar 29, 2024

I actually don't think this is correct – at least the Publish to NPM action has successful runs from a tag. I think avoiding secrets being misused is intended to already be ensured by only the team being allowed to run these actions manually.

@fhanau
Copy link
Collaborator

fhanau commented Mar 29, 2024

In fact, maybe we should recommend to use the release tag in case there are changes on main that add new APIs that aren't part of the actual release yet.

@garrettgu10
Copy link
Collaborator

Shoild we also update guidance for workers-types?

@Warfields
Copy link
Contributor Author

I agree with @fhanau.

Shoild we also update guidance for workers-types?

Yes.

Added explanation on why release actions are done on main, not on the
release tag.
@Warfields Warfields merged commit 852e2aa into main Mar 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants